Migrate "test/unit/test_providers_kms_master_key_provider.py" from unittest to pytest #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
December 12, 2018 18:33
mattsb42-aws
requested changes
Dec 15, 2018
| def setUp(self): | ||
| class TestKMSMasterKeyProvider(object): | ||
| @pytest.fixture(autouse=True) | ||
| def apply_fixtures(self): |
There was a problem hiding this comment.
Same as #127 : need to run teardown actions.
| @@ -11,8 +11,6 @@ | |||
| # ANY KIND, either express or implied. See the License for the specific | |||
| # language governing permissions and limitations under the License. | |||
| """Unit test suite from aws_encryption_sdk.key_providers.kms.KMSMasterKeyProvider""" | |||
| import unittest | |||
|
|
|||
| import botocore.client | |||
| import pytest | |||
| import six | |||
There was a problem hiding this comment.
Need to remove now-unused import.
mattsb42-aws
approved these changes
Dec 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #99
Description of changes:
Migrated "test/unit/test_providers_kms_master_key_provider.py" from unittest to pytest
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.